CATALOG-2408 - Allow template property for optionChange #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team |
lord2800
reviewed
Feb 21, 2018
src/api/product-attributes.js
Outdated
| @@ -21,9 +21,9 @@ export default class extends Base | |||
| * @param {Object} params | |||
| * @param callback | |||
| */ | |||
| optionChange(productId, params, callback) { | |||
| optionChange(productId, params, template=null, callback) { | |||
There was a problem hiding this comment.
I'd do something like
if (typeof template === 'function') {
let temp = callback;
callback = template;
template = temp;
}
immediately at the top of the function. That gives you a modicum of backwards compatibility.
There was a problem hiding this comment.
Added! Gonna test it now...
bookernath
force-pushed
the
optionChange_template
branch
3 times, most recently
from
4ed83ba to
573aa1f
Compare
|
bigcommerce/cornerstone#1167 related cornerstone PR |
bookernath
force-pushed
the
optionChange_template
branch
2 times, most recently
from
25396da to
7693d8f
Compare
|
@lord2800 linter is happy, re-review? |
|
I confirmed this doesn't break existing Cornerstone if I use it without any code changes in the theme, so I believe it to be backwards compatible. |
bookernath
force-pushed
the
optionChange_template
branch
from
7693d8f to
d30177d
Compare
bookernath
force-pushed
the
optionChange_template
branch
from
d30177d to
584d061
Compare
lord2800
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case where I need to return part of the product options payload as rendered HTML. Therefore, I need to be able to send a template property.